Re: [PATCH 1/5] maint: ensure that MB_CUR_MAX is defined even when !MBS_SUPPORT

[Paolo Bonzini]

On 10/10/2011 09:49 AM, Jim Meyering wrote:
> Hi Paolo, Arnold,
>
> Thanks, but actually, I would not like a dfa.c patch that adds a
> new global variable like that (even if it were "static").

Yes, I would not use a new global variable.  However, I'd prefer to have 
indeed separate #defines (DFA_MB_CUR_MAX, GREP_MB_CUR_MAX).

> Why avoid redefining MB_CUR_MAX at all?
> The only reason I've heard is that "it might cause problems."
> Yet I know of no system on which it does.

No, that is not a reason.  The reason is that then MB_CUR_MAX would be 
inconsistent with the behavior of mbrlen and similar functions.  Using a 
different symbol makes it clearer that the definition is special.

Paolo