bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: EGexecute: don't assume buffer ends in a newline


From: Paolo Bonzini
Subject: Re: EGexecute: don't assume buffer ends in a newline
Date: Mon, 24 May 2010 11:10:37 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.4

On 05/24/2010 02:59 AM, Bruno Haible wrote:
+      /* Here, either end < buflim&&  *end == eol, or end == buflim.  */

        /* If we've made it to this point, this means DFA has seen
           a probable match, and we need to run it through Regex. */
-      best_match = end;
+      best_match = end + 1;

Shouldn't this be

  best_match = end + (end < buflim);

?

Otherwise, the patch seems okay.  Are you going to patch Fexecute too?

Thanks,

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]