bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] dfa: fix sigsegv on multibyte character classes


From: Jim Meyering
Subject: Re: [PATCH] dfa: fix sigsegv on multibyte character classes
Date: Tue, 23 Mar 2010 17:25:07 +0100

Paolo Bonzini wrote:
> Reported by Jaroslav Škarvada <address@hidden>.  This is
> unfortunate.  grep needs an automatic testcase generator.
>
> * NEWS: Document bug.
> * THANKS: Mention reporter.
> * src/dfa.c (set_bit_casefold): Change type of first argument for
> self-documentation.
> (parse_bracket_exp): Fix call.
> * tests/Makefile.am: Add new testcase.
> * tests/char-class-multibyte: New testcase.
...
> +** Bug fixes
> +
> +  Character classes could cause a segmentation fault if they included a
> +  multibyte character.  This is a regression from 2.5.4.

Thanks for looking at that.
Did you realize that this test now always fails when built on x86_64
on both F11 and F12, and both with and without included regex?
Hmm... it appears to fail *everywhere*:

  http://hydra.nixos.org/jobset/gnu/grep-master




reply via email to

[Prev in Thread] Current Thread [Next in Thread]