bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: clean up fedora.sh


From: Paolo Bonzini
Subject: Re: [PATCH] tests: clean up fedora.sh
Date: Sun, 14 Mar 2010 16:38:47 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.1

On 03/14/2010 12:18 PM, Jim Meyering wrote:
The new fedora.sh test was annoyingly slow.
Yeah, 3 seconds is "slow" for some of us ;-)

This fixes it, along with a little clean up and concurrency-protection.
It relies on the "timeout" program[0], but if it's not available,
the three sub-tests that require that are silently skipped.

Good! Can you rename it to just "fedora" so that we can have the convention that ".sh" implies having to convert to the new testsuite?

I also wanted to do some valgrind testing, but I ended up patching the test files. Wouldn't it be easier if they still used $GREP?

Thanks,

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]