Re: [PATCH 03/17] dfa: get rid of x*alloc

[Jim Meyering]

Paolo Bonzini wrote:
> * src/dfa.c: Include xalloc.h.
> (xmalloc, xrealloc, xcalloc): Remove.
> ---
>  src/dfa.c |   35 ++---------------------------------
>  src/dfa.h |   12 ------------
>  2 files changed, 2 insertions(+), 45 deletions(-)
>
> diff --git a/src/dfa.c b/src/dfa.c
...

The part above, described in the log, is fine.

However, the following ptr_t-removing change to dfa.h
doesn't belong in this change set.

> diff --git a/src/dfa.h b/src/dfa.h
> index f13a257..cff2b0b 100644
> --- a/src/dfa.h
> +++ b/src/dfa.h
> @@ -23,18 +23,6 @@
>     In addition to clobbering modularity, we eat up valuable
>     name space. */
>
> -#ifdef __STDC__
> -# ifndef _PTR_T
> -# define _PTR_T
> -  typedef void * ptr_t;
> -# endif
> -#else
> -# ifndef _PTR_T
> -# define _PTR_T
> -  typedef char * ptr_t;
> -# endif
> -#endif
> -
>  /* Number of bits in an unsigned char. */
>  #ifndef CHARBITS
>  #define CHARBITS 8