Re: --show-c-function and --show-function-line=RE (was Re: [patch #3644] --initial-tab and 3 newly colorized items) [bug-grep]

[Stepan Kasal]

Hi,

On Wed, Jan 26, 2005 at 03:59:26PM -0500, Charles Levert wrote:
> > >On Jan 26, 2005, at 07:46, Stepan Kasal wrote:
> > >>I also think that the --show*function options should eventually go in.

OK, I made my decision too quick here.

>   1) changes to make src/dfa.c handle several regexps (specific layer;
>      "grep", "grep -E", and "grep -X awk");
> 
>   2) changes to make src/search.c handle several regexps (generic layer;
>      enough for "grep -P" because of the existing properties of the PCRE
>      interface, and "grep -F");
> 
>   3) changes to implement --show-c-function and --show-function-line.

Thanks for the explanation.  I haven't imagine that patch required 1) and 2).

I should remind that our goal now is to produce a bugfix release 2.5.2.
(Changes to --color option and -T should not affect people who are not using
them, which is why we can accept them.)

So we should not accept changes like 1) or 2) now.

Then, we'll open a development branch, 2.6.
Then there are some interesting patches waiting.

I'm afraid it'd be better to put off the resolution about your
--show*function patches until then.
(And I have to admit that when this patch is so complex, it seems that it's
not worth the additional maintainer work it would bring.)
I used to think I'm indecisive, but I'm not so sure any more.

Stepan