[bug #30094] (Regression) FTBFS on GNU/kFreeBSD: sync.m:87: error: 'PTHREAD_MUTEX_RECURSIVE' undeclared

[Yavor Doganov]

URL:
  <http://savannah.gnu.org/bugs/?30094>

                 Summary: (Regression) FTBFS on GNU/kFreeBSD: sync.m:87:
error: 'PTHREAD_MUTEX_RECURSIVE' undeclared
                 Project: GNUstep
            Submitted by: yavor
            Submitted on: Wed Jun  9 14:38:36 2010
                Category: Base/Foundation
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

1.20.0 fails to build on GNU/kFreeBSD with the following error:

gcc sync.m -c \
              -MMD -MP -Wall -Wdeclaration-after-statement -DGNUSTEP
-DGNUSTEP_BASE_LIBRARY=1 -DGNU_RUNTIME=1 -DGNUSTEP_BASE_LIBRARY=1 -D_REENTRANT
-fPIC -Wall -DGSWARN -DGSDIAGNOSE -Wno-import -g -O2 -fno-strict-aliasing
-fexceptions -fobjc-exceptions -D_NATIVE_OBJC_EXCEPTIONS -fgnu-runtime
-fgnu-runtime -fconstant-string-class=NSConstantString
-I../../Headers/Additions -I../. -I../ -I../../Headers -I.
-I/usr/include/GNUstep -I/usr/local/include/GNUstep
-I/usr/local/include/GNUstep -I/usr/include/libxml2 -I/usr/include
-I/usr/local/include/GNUstep -I/usr/include/GNUstep \
               -o obj/ObjectiveC2.obj/sync.m.o
sync.m: In function 'initLockObject':
sync.m:87: warning: implicit declaration of function
'pthread_mutexattr_settype'
sync.m:87: error: 'PTHREAD_MUTEX_RECURSIVE' undeclared (first use in this
function)
sync.m:87: error: (Each undeclared identifier is reported only once
sync.m:87: error: for each function it appears in.)
make[5]: *** [obj/ObjectiveC2.obj/sync.m.o] Error 1

Trivial patch attached.

GNU libc supports several kernels: Linux, GNU Mach+Hurd, kFreeBSD and
(unofficially) kOpenSolaris.  So the correct check in this case is for the
symbol __GLIBC__, which is guaranteed to be defined on all glibc-based
platforms.  
Perhaps it's worth to leave __linux__ for the rare cases when another libc is
used with Linux (uClibc, dietlibc, etc.), although I'm not sure if the GNUstep
stack works on those systems at all.

Thanks.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed Jun  9 14:38:36 2010  Name: kfreebsd.patch  Size: 610B   By: yavor

<http://savannah.gnu.org/bugs/download.php?file_id=20708>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?30094>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/