bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GNUstep Printing Backend Patch and such


From: Adam Fedor
Subject: Re: GNUstep Printing Backend Patch and such
Date: Mon, 5 Jul 2004 22:11:11 -0600


On Jul 5, 2004, at 6:07 PM, Chad Hardin wrote:

- My opinion is that the new printing bundles should not be situated inside of GUI, but in some directory alongside to it, taking that huge amount of PPD files with them.

Ok, I have no opinion either way, so I'll defer to the *step leadership... :-) BTW, this is by means the final version, this is just "Round One". Much more is to follow....

I think it should go in gui. It's not likely to be that large and it should be installed with the gui library. I think the PPD files should be removed, though, and put somewhere else.

Yeah, that was one of those things that seemed like a good idea at the time. :-). I had read the FSF and GNUstep coding standards (http://www.gnustep.org/resources/documentation/Developer/ CodingStandards/coding-standards_3.html#SEC3) and thought that while I was "in the code" I would set everything right. Of course, I wasn't thinking about what it would look like when someone would look at the patch.

We'd prefer that people don't reformat the code just to make it look nicer, as it makes it difficult to look through a patch and see what has really changed. I know how hard this can be, having somewhat of a "neat and tidy" fetish myself. One could, however, put together a patch that says, "this patch makes the code look nicer and makes no other changes at all", so that people don't have to go looking through the patch in detail.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]