bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Proposal to fix NSCell issue


From: Quentin Mathé
Subject: Re: [PATCH] Proposal to fix NSCell issue
Date: Tue, 23 Mar 2004 01:07:14 +0100

Le 20 mars 04, à 02:57, Alexander Malmberg a écrit :

When working with cells and views, it's important to remember that the
connections between cells and views are not simple. :)

In particular, a single cell might be shared by multiple views, so a
cell does not have any defined "control view" (except when it's inside a
-...inView: call, and even then there are some interesting reentrancy
issues). Thus, adding a new supercell ivar is almost certainly wrong.

-performClick: is ugly in that it doesn't properly handle this.
-performClickWithFrame:inView: seems like a much better replacement, so
I'm in favor of adding it and deprecating [NSCell -performClick:].

Well, here is two patches which add -performClickWithFrame:inView: to NSCell and mark performClick: as deprecated.
If everybody is ok, I can commit this NSCell modification.

Quentin.

Attachment: NSCell.h.patch
Description: Binary data

Attachment: NSCell.m.patch
Description: Binary data



--
Quentin Mathé
qmathe@club-internet.fr

reply via email to

[Prev in Thread] Current Thread [Next in Thread]