NSMenuView and popups (was: Re: [PATCH] Menus in lowerleft corner)

[Michael Hanni]

Hi Willem,

--- Willem Rein Oudshoorn <woudshoo@xs4all.nl> wrote:
>
> Testing
> -------
> 
> Could someone who experiences these problems test out this 
> patch and let me know the result?

This patch works like a dream... Very nice work.

In testing this I came across a small issue in the popup buttons which was the
result not of this patch but your previous NSMenuView work. It seems that even
popupbuttons have an NSMenuViewWindowTitle (off the top of my head I can't
remember the name) assigned to them... Thus, if you manipulate a popup like the
several in GWorkspace you get some weird behavior. If the popup needs more than
a split second to complete its action you get a weird size/resize shuffle with
a titlebar.

Since the NSMenuViewWindowTitleBar-thingie is created in NSMenuView's
initWithFrame, and the NSMenu creating the NSMenuView doesn't know its owned by
a popup until right after its init, we are slightly screwed. I suppose we could
catch this on the first sizeToFit in NSMenuView -- like we catch the left
offset?

Oh, one other thing... the "filesystem depth" popup in GWorkspace windows
should really sizeToFit after it changes its title -- i.e. you get a long
directory name that goes right out the side. Does sizeToFit in NSPopUpButton
work still (there were some issues with the _cellSize not getting set properly
I think)?

Anyhow, awesome work.

Michael