Re: [PATCH] NSMenu patch version 2.

[Fred Kiefer]

Hi Wim,

menus kep on appearing in the lower left corner for me as well. It would 
be great if you could resolve this problem quickly.

What I did not understadnd about your changes is the introduction of the 
NSMenuView protocol. I could not find this in my MacOSX documentation 
and I also see no additional value in it. The code in the (deprecated) 
method setMenuRepresentation: checks if the handed in view is a subclass 
of NSMenuView, so anything else never could be used. Also most of the 
interaction between the MenuView and the Menu is generic and will be 
used by all menu views, whichever way they will draw. I would say that 
allowing for subclasses is sufficient here. And perhaps we could even 
move some of the declaration of the interface between the menu and its 
view into a private file.

Cheers
Fred

Willem Rein Oudshoorn wrote:
> Michael Hanni <michael@deviant-behavior.com> writes:
> > I tried this patch and it does some nice stuff, though my biggest pet peeve
> > with the menus still exists. That is, if you click on a menu item and drag up
> > and down the menu after a few passes you start getting menu windows showing up
> > at (0,0). 
> >
> > Are you seeing this as well? I looked into this a little this afternoon, but I
> > didn't see anything that jumped out at me.
>
>
> Yes, I have seen this as well.  I think this bug is related to
>
> #101876 - Menus do not dissappear.
>
> Which is not fixed.  I have strong suspicion that the
> bug is not in the NSMenu code, but that the frequently
> mapping/unmapping windows bring to light a bug
> in the x11 part of back. 
>
> Also, running GNUstep applications insided Xnest and
> WindowMaker with sloppy focuse will make it much 
> easier to reproduce this behaviour.  
> This is also a reason I suspect the x11 part of back.
>
> I was planning to look into it.  But did not want
> to have this bug delay the rest of the patch. 
> But if you want to hunt this one down, go ahead :-)