Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

[H. Langos]

On Sat, May 23, 2009 at 01:11:41PM +0200, Richard van den Berg wrote:
> On 5/22/09 11:38 PM, H. Langos wrote:
>> Just commited it all to CVS.
>> Please take a look and see if it does the right thing for your music
>> collection.
>>   
>
> Great. It works fine with my mp3s (that just contain ReplayGain info in  
> APE tags).
>
>> Let me know if you find any bugs.
>>   
>
> I looked over the code and it seems clean to me.. but I didn't test with  
> RVAD / RVA2 tagged files.

One thing to keep in mind is that the --min-vol-adj and --max-vol-adj now
only affect the RVA/RVAD tag information instead of something extracted 
from RVA2 tags. (I need to update the help text about that.)

Those options were probably introduced because having iTunNORM comments AND
RVA2 tags on one file would have led to very loud results.

Now RVA2/XRVA tags are read instead of iTunNORM comments and we might either
get rid of those options or supplement them with --min-db-adj and
--max-db-adj to limit the adjustment that goes into the soundcheck
attribute. 

cheers
-henrik