bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Pacify -Wmissing-variable-declarations in unit tests.


From: Collin Funk
Subject: Pacify -Wmissing-variable-declarations in unit tests.
Date: Sat, 27 Apr 2024 23:52:16 -0700
User-agent: Mozilla Thunderbird

When building Coreutils I noticed that GCC 14's
-Wmissing-variable-declarations option spams the test output.

Can I apply the attached patch which adds the 'static' specifier to
global variables in unit tests?

Or would it be better to just disable the warning in tests? I'm used
to marking things static even in small single file programs, but maybe
others will forget the convention.

I think a few of the unistr, etc. tests also trigger this warning. I
left them unchanged since IIRC most are auto-generated.

Collin

Attachment: 0001-Pacify-Wmissing-variable-declarations-in-unit-tests.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]