[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gnulib-tool: Improve handling of multiple --local-dir options
From: |
Pavel Raiskup |
Subject: |
Re: gnulib-tool: Improve handling of multiple --local-dir options |
Date: |
Tue, 19 Feb 2019 16:39:32 +0100 |
Thanks for working on this, Bruno! Only nits..
On Thursday, February 14, 2019 8:53:33 PM CET Bruno Haible wrote:
> [...]
> This patch fixes both issues, and makes the IFS handling a bit more robust.
> [...]
> - case $_fpf_arg in
> + case "$_fpf_arg" in
> [...]
> - fpf_dirs=$1 ; shift
> - fpf_cb=$1 ; shift
> + fpf_dirs="$1"; shift
> + fpf_cb="$1"; shift
> [...]
... and so on, I don't think it is more robust. At least according to
Autoconf's Shellology [1] it should be actually better to write it the
other way around (without additional quotes).
FTR, Gary Vaughan has wrote a syntax checker rules for protecting us from
adding such statements into libtool codebase.
[1] https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/
Shell-Substitutions.html
Pavel