[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: new module 'strtold'
From: |
Pádraig Brady |
Subject: |
Re: new module 'strtold' |
Date: |
Tue, 29 Jan 2019 21:42:56 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 29/01/19 19:05, Bruno Haible wrote:
> Hi,
>
> coreutils has recently started to use strtold() [1]. This causes compilation
> errors on Android 4.3:
>
> CC lib/cl-strtod.o
> CC lib/cl-strtold.o
> In file included from ../lib/cl-strtold.c:2:
> ../lib/cl-strtod.c: In function 'cl_strtold':
> ../lib/cl-strtod.c:62: warning: implicit declaration of function 'strtold'
Oh wow, thanks for doing all that.
We previously guarded uses of strtold in coreutils with:
https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.5-8-g8b5087d
which did:
#if HAVE_C99_STRTOLD /* provided by c-strtold module. */
# define STRTOD strtold
#else
# define STRTOD strtod
#endif
long double a = STRTOD (sa, &ea);
We should have guarded the new code similarly.
With this new module though we've more consistent functionality
across all platforms.
thanks!
Pádraig