bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

relocatable-prog: avoid warnings from Automake


From: Akim Demaille
Subject: relocatable-prog: avoid warnings from Automake
Date: Wed, 23 Jan 2019 22:48:23 +0100

Hi Ben,

This is what I get currently:

 cd bison && /bin/sh build-aux/missing automake-1.16 --gnu Makefile
lib/gnulib.mk:1677: warning: .PHONY was already defined in condition TRUE, 
which includes condition RELOCATABLE_VIA_WRAPPER ...
Makefile.am:71:   'lib/local.mk' included from here
lib/local.mk:16:   'lib/gnulib.mk' included from here
doc/local.mk:168: ... '.PHONY' previously defined here
Makefile.am:68:   'doc/local.mk' included from here

this is because relocatable-prog's Makefile snippet uses .PHONY in a 
conditional.  AFAICT the only difference is that when not enabled, "make 
uninstall-relocwrapper" will do nothing instead of being an error.  The 
rigorous alternative would be to define a variable in the conditional and use 
it in .PHONY.  Would you prefer that?

commit e460bdd044600c46cea452b66d419ce01fff30d8
Author: Akim Demaille <address@hidden>
Date:   Wed Jan 23 22:42:04 2019 +0100

    relocatable-prog: avoid warnings from Automake
    
    * modules/relocatable-prog: Don't declare PHONY dependencies in
    Automake conditionals.

diff --git a/ChangeLog b/ChangeLog
index b9e15a10a..e9a745ee9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2019-01-23  Akim Demaille  <address@hidden>
+
+       relocatable-prog: avoid warnings from Automake
+       * modules/relocatable-prog: Don't declare PHONY dependencies in
+       Automake conditionals.
+
 2019-01-23  Akim Demaille  <address@hidden>
 
        array-list: Pacify warnings about unused arguments (-Wunused-parameter).
diff --git a/modules/relocatable-prog b/modules/relocatable-prog
index ee6fcf5e7..60ebb239a 100644
--- a/modules/relocatable-prog
+++ b/modules/relocatable-prog
@@ -45,8 +45,8 @@ uninstall-relocwrapper:
                       uninstall ;; \
          esac; \
        fi
-.PHONY: uninstall-relocwrapper
 endif
+.PHONY: uninstall-relocwrapper
 
 Include:
 "relocatable.h"




reply via email to

[Prev in Thread] Current Thread [Next in Thread]