[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: new module suggestion: fprintftime-check
From: |
Bruno Haible |
Subject: |
Re: new module suggestion: fprintftime-check |
Date: |
Fri, 28 Dec 2018 17:34:18 +0100 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; ) |
Hi Assaf,
> This function enables syntax-check of the format string.
First question: Should this syntax-check be integrated into the
nstrftime() and fprintftime() functions? These functions are gnulib
inventions, therefore they could be extended to return
- an error indicator (maybe EINVAL?),
- a detailed error message, if you like,
- a pointer to the wrong directive in the format string, if you like.
Or is it better to have a function that does only the syntax check,
and document that nstrftime() and fprintftime() should only be called
after the syntax check has been done?
(I have no preference. Just asking.)
> I'd like to suggest the following new module: fprintftime-check.
For a module that does only the syntax check, I would suggest a
different name:
- The prefix 'fprint' indicates output to a 'FILE *'.
- The prefix 'str' indicates output to a 'char *' buffer.
Why not call it 'ftime-check' or 'check-ftime'?
> It uses the same infrastructure as fprintftime
> (i.e. #include "nstrtime,c")
That's a good idea, otherwise the syntax check and the actual use of
the format string might too easily get out-of-sync.
> This patch is only a rough draft
tzalloc() may fail and return NULL. (And why would parsing the format
string be dependent on a particular time zone at all?)
Bruno