[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Avoid having GNULIB_NAMESPACE::func always inject references
From: |
Pedro Alves |
Subject: |
Re: [PATCH] Avoid having GNULIB_NAMESPACE::func always inject references to rpl_func |
Date: |
Mon, 21 Nov 2016 23:33:03 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 11/21/2016 11:27 PM, Bruno Haible wrote:
> Pedro Alves wrote:
>> How about breaking this line like the rpl method was breaking it, in order
>> to avoid overly-long lines?
>>
>> inline operator type () const
>> { return reinterpret_cast<type>((rettype2 (*)
>> parameters2)(::func)); }
>>
>> Likewise the other similar cases.
>
> If line breaking it needed, I prefer the GNU style for functions,
That's fine with me. (The single-line {...} style comes from libstdc++.)
> and do it systematically. It takes more vertical space, but it
> make is easier to compare the different variants of _gl_ ## func ## _wrapper.
Agreed, that's what I was thinking when suggesting to give
the other similar cases the same treatment.
Thanks,
Pedro Alves
Re: [PATCH] Avoid having GNULIB_NAMESPACE::func always inject references to rpl_func, Bruno Haible, 2016/11/20