Re: getprogname: comments and test failure on Cygwin

[Jim Meyering]

On Tue, Oct 18, 2016 at 6:07 AM, Daiki Ueno <address@hidden> wrote:
> Hello,
>
> Jim Meyering <address@hidden> writes:
>
>> On Sun, Oct 16, 2016 at 5:15 AM, Pádraig Brady <address@hidden> wrote:
>>> On 16/10/16 12:55, Bruno Haible wrote:
>>>> Hi,
>>>>
>>>> The 'getprogname' module test fails on Cygwin 2.6, because the returned
>>>> value is "test-getprogname", not "test-getprogname.exe". (On mingw, on the
>>>> other hand, it really is "test-getprogname.exe".)
>
> On a related note, this new test also fails when it is invoked as a
> libtool wrapper script, because of the "lt-" prefix.
>
> $ ./gnulib-tool --create-testdir --dir t --libtool getprogname
> $ cd t && ./configure
> $ sed -i 's/^noinst_LTLIBRARIES +=/lib_LTLIBRARIES =/' gllib/Makefile.am
> $ make && make check
>
> FAIL: test-getprogname
> ======================
>
> lt-test-getprogname: test-getprogname.c:29: main: Assertion `STREQ (p, 
> "test-getprogname" EXEEXT)' failed.
> FAIL test-getprogname (exit status: 134)
>
> Sorry for not providing a patch.  I have no idea how to conditionalize
> this in the test program itself.

Thank you both.
Here is a proposed patch:

gnulib-gethostname-lt-exe.diff
Description: Text document