[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: quotearg test failures
From: |
Padraig Brady |
Subject: |
Re: quotearg test failures |
Date: |
Mon, 17 Oct 2016 21:08:51 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
Bruno Haible wrote:
> I disagree with the removal of the '%' checks in tests/test-sh-quote.c
Agreed. There is a disparity now because there is a switch
from a longer (shell) to a more concise (c) quoting style
in certain cases (when just a single quote is encountered).
This is fine for most interfaces as the size is passed in,
and we don't write beyond that.
Though for the shell_quote, case shell_quote_length() is separate,
and thus returns too small a value for the coupled shell_quote_copy().
I'll fix this up either by unsetting a new USE_MOST_CONCISE option
from shell_quote_{length,copy}, or implicitly only doing this
more concise representation for "shell-escape" mode.