Re: fix obsolete uses of AC_MSG_NOTICE

[Pádraig Brady]

On 16/10/16 15:09, Bruno Haible wrote:
> Hi,
> 
> In the configure output of a full gnulib testdir, we have thousands of
> "checking ..." messages but also 2 times "configure: checking ..."
> 
> ...
> checking whether fflush works on input streams... (cached) no
> checking for _fseeki64... no
> checking whether fstatat (..., 0) works... yes
> checking for sys/mount.h... yes
> configure: checking how to get file system space usage
> checking for statvfs function (SVR4)... yes
> checking whether to use statvfs64... no
> checking for two-argument statfs with statfs.f_frsize member... yes
> checking dustat.h usability... no
> checking dustat.h presence... no
> checking for dustat.h... no
> checking sys/fs/s5param.h usability... no
> checking sys/fs/s5param.h presence... no
> checking for sys/fs/s5param.h... no
> checking sys/filsys.h usability... no
> checking sys/filsys.h presence... no
> checking for sys/filsys.h... no
> checking sys/statfs.h usability... yes
> checking sys/statfs.h presence... yes
> checking for sys/statfs.h... yes
> checking for statfs that truncates block counts... no
> checking for ftello... (cached) yes
> checking whether ftello works... (cached) yes
> checking for struct statfs.f_type... yes
> checking whether __func__ is available... yes
> checking whether futimens works... needs runtime check
> checking for mmap... (cached) yes
> checking for MAP_ANONYMOUS... yes
> checking for mmap... (cached) yes
> checking for MAP_ANONYMOUS... yes
> configure: checking how to do getaddrinfo, freeaddrinfo and getnameinfo
> checking for library containing getaddrinfo... none required
> checking for getaddrinfo... yes
> ...
> 
> I propose to remove the 'configure: ' prefix in these two lines.
> 
> 
> 2016-10-16  Bruno Haible  <address@hidden>
> 
>       Simplify "configure: checking ..." messages.
>       * m4/fsusage.m4 (gl_FILE_SYSTEM_USAGE): Use AC_MSG_CHECKING instead of
>       AC_MSG_NOTICE.
>       * m4/getaddrinfo.m4 (gl_GETADDRINFO): Likewise.
> 
> diff --git a/m4/fsusage.m4 b/m4/fsusage.m4
> index 0cbeec6..72472e2 100644
> --- a/m4/fsusage.m4
> +++ b/m4/fsusage.m4
> @@ -1,4 +1,4 @@
> -# serial 30
> +# serial 31
>  # Obtaining file system usage information.
>  
>  # Copyright (C) 1997-1998, 2000-2001, 2003-2016 Free Software Foundation, 
> Inc.
> @@ -36,7 +36,7 @@ dnl of field f_blocks in 'struct statfs' from 32 bit to 64 
> bit on
>  dnl Mac OS X >= 10.5 (32-bit mode).
>  AC_REQUIRE([AC_SYS_LARGEFILE])
>  
> -AC_MSG_NOTICE([checking how to get file system space usage])
> +AC_MSG_CHECKING([how to get file system space usage])
>  ac_fsusage_space=no
>  
>  # Perform only the link test since it seems there are no variants of the
> diff --git a/m4/getaddrinfo.m4 b/m4/getaddrinfo.m4
> index 2af1e01..4a92d08 100644
> --- a/m4/getaddrinfo.m4
> +++ b/m4/getaddrinfo.m4
> @@ -1,4 +1,4 @@
> -# getaddrinfo.m4 serial 30
> +# getaddrinfo.m4 serial 31
>  dnl Copyright (C) 2004-2016 Free Software Foundation, Inc.
>  dnl This file is free software; the Free Software Foundation
>  dnl gives unlimited permission to copy and/or distribute it,
> @@ -8,7 +8,7 @@ AC_DEFUN([gl_GETADDRINFO],
>  [
>    AC_REQUIRE([gl_HEADER_SYS_SOCKET])dnl for HAVE_SYS_SOCKET_H, 
> HAVE_WINSOCK2_H
>    AC_REQUIRE([gl_HEADER_NETDB])dnl for HAVE_NETDB_H
> -  AC_MSG_NOTICE([checking how to do getaddrinfo, freeaddrinfo and 
> getnameinfo])
> +  AC_MSG_CHECKING([how to do getaddrinfo, freeaddrinfo and getnameinfo])
>    GETADDRINFO_LIB=
>    gai_saved_LIBS="$LIBS"

makes sense.
thanks