Re: [PATCH 01/21] gnulib-tool: disable a symbolic link on OS/2

[Paul Eggert]

KO Myung-Hun wrote:
> +# OS/2 does not support a symbolc link at all
> +case `uname -s` in
> +  "OS/2") no_symlink_support=true;;
> +  *) no_symlink_support=;;
> +esac

Surely it would be better to test this directly, by running 'ln -s' and seeing 
it fail, than to look at operating system names.

'symbolc' is misspelled.

gnulib-tool uses 'true' and 'false' for boolean flags.  See, e.g., 
'have_associative'.

Use a positive flag 'have_symlinks' rather than a negative flag 
'no_symlink_support'; that's less confusing and uses the existing naming 
convention better.

If symbolic links are not available, it's better for 'gnulib-tool --symbolic' to 
quickly fail instead of quietly succeed without using symbolic links.