[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] A new module called streq_macros that provides STREQ and STR
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] A new module called streq_macros that provides STREQ and STRNEQ |
|
Date: |
Wed, 21 May 2014 13:55:56 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/21/2014 01:49 PM, Eric Blake wrote:
> On 05/21/2014 01:15 PM, Kieran Colford wrote:
>> ---
>> modules/streq_macros | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>> create mode 100644 modules/streq_macros
>>
>> @@ -0,0 +1,24 @@
>> +Description:
>> +Add the macros STREQ and STRNEQ to config.h. This adds the
>> +functionality that is looked for by sc_prohibit_strcmp from the
>> +maintainer-makefile.
>> +
Also, if you add this module, you'll need to adjust several other files.
For example, lib/fnmatch.c currently assumes it can blindly #define
STREQ; that would need to be made conditional (#ifndef STREQ) or else
rely on a module dependency, so that the config.h definition doesn't
collide with a definition in fnmatch.c.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature