[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [libvirt] [PATCH] Fix build of portallocator on mingw
|
From: |
Eric Blake |
|
Subject: |
Re: [libvirt] [PATCH] Fix build of portallocator on mingw |
|
Date: |
Thu, 20 Feb 2014 05:54:34 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/20/2014 05:38 AM, Eric Blake wrote:
> [adding gnulib]
>
> On 02/20/2014 02:39 AM, Ján Tomko wrote:
>> IN6ADDR_ANY_INIT does not seem to be working as expected on MinGW:
>> error: missing braces around initializer [-Werror=missing-braces]
>> .sin6_addr = IN6ADDR_ANY_INIT,
>>
>> Use the in6addr_any variable instead.
>>
>> Reported by Daniel P. Berrange.
>> ---
>> Pushed as a build breaker.
>
> For libvirt, I'm half tempted to just kill -Wmissing-braces on platforms
> whose headers don't have enough {}. Have we filed a bug report against
> mingw's headers yet?
Done:
https://bugzilla.redhat.com/show_bug.cgi?id=1067426
>
> Also, perhaps gnulib could be taught to work around the problem.
Particularly since gnulib is already providing a <netinet/in.h> for
mingw since mingw currently lacks it natively.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature