[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] warnings: check -Wfoo rather than -Wno-foo
From: |
Paul Eggert |
Subject: |
Re: [PATCH] warnings: check -Wfoo rather than -Wno-foo |
Date: |
Wed, 14 Aug 2013 16:49:30 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 |
Eric Blake wrote:
> - gl_AS_VAR_APPEND(m4_defn([gl_Flags]), [" $gl_unknown_warnings_are_errors
> $1"])
> + gl_AS_VAR_APPEND(m4_defn([gl_Flags]),
> + [" $gl_unknown_warnings_are_errors ]m4_bpatsubst([$1], [^-Wno-],
> [-W])["])
This assumes that gl_COMPILER_OPTION_IF's argument is
a constant, so won't it have trouble with the following
common idiom (this example taken from coreutils/configure.ac)?
gl_MANYWARN_ALL_GCC([ws])
gl_MANYWARN_COMPLEMENT([ws], [$ws], [$nw])
for w in $ws; do
gl_WARN_ADD([$w])
done
gl_WARN_ADD calls gl_COMPILER_OPTION_IF.
- gl_WARN_ADD does not work with -Wno-xxxx warnings, Christophe Fergeau, 2013/08/14
- Re: gl_WARN_ADD does not work with -Wno-xxxx warnings, Eric Blake, 2013/08/14
- [PATCH] warnings: check -Wfoo rather than -Wno-foo, Eric Blake, 2013/08/14
- Re: [PATCH] warnings: check -Wfoo rather than -Wno-foo,
Paul Eggert <=
- Re: [PATCH] warnings: check -Wfoo rather than -Wno-foo, Eric Blake, 2013/08/15
- [PATCH] warnings: extend -Wno-foo handling to work through shell vars, Eric Blake, 2013/08/15
- Re: [PATCH] warnings: extend -Wno-foo handling to work through shell vars, Eric Blake, 2013/08/15
- Re: [PATCH] warnings: extend -Wno-foo handling to work through shell vars, Paul Eggert, 2013/08/15
- Re: [PATCH] warnings: extend -Wno-foo handling to work through shell vars, Eric Blake, 2013/08/15
- Re: [PATCH] warnings: check -Wfoo rather than -Wno-foo, Christophe Fergeau, 2013/08/19