[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: cppcheck error in opendir.c
From: |
Paul Eggert |
Subject: |
Re: cppcheck error in opendir.c |
Date: |
Wed, 20 Mar 2013 09:54:36 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/20/13 09:38, Arno Onken wrote:
> It is explained in the second post on the bug tracker:
Sorry, I don't know the bug tracker in question.
> Comment(by amai):
>
> Well, I am just looking at lib/opendir.c - and I have no idea about the
> correlation of involved macros ''HAVE_OPENDIR'' and ''REPLACE_FCHDIR'' ...
> So ''ifndef HAVE_OPENDIR'' and ''#ifdef REPLACE_FCHDIR'' cppcheck is
> right, ''dirp'' is allocated by ''malloc()'' and passed to ''closedir()''.
But in that case, closedir is implemented via malloc, no?
So it should be OK. We are talking about the *implementation*
of opendir here, so there should be some license for it to
know DIR internals.