[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Test failure on Mac OS 10.8.2
From: |
Gary V. Vaughan |
Subject: |
Re: Test failure on Mac OS 10.8.2 |
Date: |
Sat, 9 Mar 2013 12:37:57 +0700 |
Hi Paul,
Thanks for applying a fix so quickly.
On 9 Mar 2013, at 00:47, Paul Eggert <address@hidden> wrote:
> On 03/08/2013 09:15 AM, Gary V. Vaughan wrote:
>
>> ../../tests/test-xvasprintf.c: In function 'test_xasprintf':
>>
>> ../../tests/test-xvasprintf.c:98: warning: format not a string literal and
>> no format arguments
>
> That looks like a bogus warning. Hope you can ignore it.
Sure, it's the only one, so isn't distracting enough to cause us to miss any
new real warnings we get later.
>> stdout has this extra line:
>>
>> 0x1p+0 33
>
> OK, thanks, it looks like the gnulib test is being too picky:
> it's insisting on round-to-even but POSIX says the rounding
> is implementation-defined. Mac OS should probably be rounding
> to even but that's not our job. I pushed the following patch.
Well, actually you patched test-vasnprintf-posix.c, where the bug I was
experiencing was in test-vasprintf-posix.c :-) I took the liberty of
applying your work-around in two more places in order to get the full
'make distcheck' tests to pass in the m4 release tree.
It seems like it might be worth a more thorough analysis of the test
cases in the test-v*printf*.c tests for other occurrences of the same
problem too, in case there are more than the three we've amended that
aren't exercised my m4 make distcheck?
Cheers,
--
Gary V. Vaughan (gary AT gnu DOT org)