[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: stat-time.h vs. -Waggregate-return
From: |
Paul Eggert |
Subject: |
Re: stat-time.h vs. -Waggregate-return |
Date: |
Thu, 02 Aug 2012 15:49:26 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120714 Thunderbird/14.0 |
On 08/02/2012 03:40 PM, Eric Blake wrote:
> /* Store *ST's access time into *TS. */
> static inline void
> get_stat_atime (struct stat const *st, struct timespec *ts)
I'd rather not go that route, as the functional style is easier
to read -- in particular, it tends to avoid aliasing issues.
In the GNU apps I'm familiar with (Emacs, coreutils, ...)
we simply disable -Waggregate-return. It a completely
anachronistic warning, since its motivation was to
support backwards compatibility with C compilers that
did not allow returning structures. Those compilers
are long dead and are no longer of practical concern.