[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: announce-gen: minor issues
From: |
Jim Meyering |
Subject: |
Re: announce-gen: minor issues |
Date: |
Wed, 23 May 2012 10:34:09 +0200 |
Akim Demaille wrote:
> Le 23 mai 2012 à 10:02, Akim Demaille a écrit :
>
>> The two attached patches provide minor improvements to
>> announce-gen. The first one was prompted by the fact
>> that I had an error message whose origin was unclear.
Hi Akim,
Thanks for the patches!
>> * build-aux/announce-gen: When parsing command line options,
>> prefer "announce-gen: option --release-type requires an argument"
>> to "Option release-type requires an argument".
This is an improvement, but for the fact that then all explicit
uses of warn would emit "$ME: $ME: ...".
What do you think about removing the "$ME: " prefix from
each existing warn argument string?
>> The second one addresses a portability issue.
>>
>> * build-aux/announce-gen (sizes): Invoke du with -h
>> instead of --human.
This looks fine, but I'd like mention in the log which system
required the change. OS/X?
Here's a proposed log message:
announce-gen: du -h is more portable than du --human
* build-aux/announce-gen (sizes): Invoke du with -h instead
of --human. Accept leading white space in its output.
These changes are required to accommodate ????'s du.