[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Ordering of "-I" flags in CPPFLAGS can lead to gnulib headers being
From: |
Bruno Haible |
Subject: |
Re: Ordering of "-I" flags in CPPFLAGS can lead to gnulib headers being skipped |
Date: |
Thu, 23 Feb 2012 21:07:55 +0100 |
User-agent: |
KMail/4.7.4 (Linux/3.1.0-1.2-desktop; KDE/4.7.4; x86_64; ; ) |
Paul Eggert wrote:
> On 02/23/2012 02:08 AM, Michael Goffioul wrote:
> > 2) in liboctave/Makefile.am, @CPPFLAGS@ should be moved to the end, or
> > after "-I../libgnu"
>
> That's what I'd do.
I would even remove @CPPFLAGS@ from the definiton of AM_CPPFLAGS.
When you look at the Automake generated Makefile.in, you will notice
that it uses
$(AM_CPPFLAGS) $(CPPFLAGS)
everywhere, and there is a definition
CPPFLAGS = @CPPFLAGS@
Therefore if you have @CPPFLAGS@ inside AM_CPPFLAGS, you have it twice in
total, which is redundant.
Bruno