[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/4] Add a test suite for the sethostname module
From: |
Ben Walton |
Subject: |
[PATCH 4/4] Add a test suite for the sethostname module |
Date: |
Fri, 2 Dec 2011 23:04:19 -0500 |
Provide a module that tests the functionality of sethostname().
Signed-off-by: Ben Walton <address@hidden>
---
ChangeLog | 6 ++
modules/sethostname-tests | 13 +++++
tests/test-sethostname.c | 117 +++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 136 insertions(+), 0 deletions(-)
create mode 100644 modules/sethostname-tests
create mode 100644 tests/test-sethostname.c
diff --git a/ChangeLog b/ChangeLog
index 67f7f42..2e85f16 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
2011-12-01 Ben Walton <address@hidden>
+ * modules/sethostname-tests: New file. A test program
+ for the sethostname module.
+ * tests/test-sethostname.c: Likewise.
+
+2011-12-01 Ben Walton <address@hidden>
+
* lib/unistd.in.h: Integrate the SETHOSTNAME preprocessor handling
into the unistd.h header.
* m4/unistd_h.m4: Setup the autoconf handling for the SETHOSTNAME
diff --git a/modules/sethostname-tests b/modules/sethostname-tests
new file mode 100644
index 0000000..040b380
--- /dev/null
+++ b/modules/sethostname-tests
@@ -0,0 +1,13 @@
+Files:
+tests/signature.h
+tests/test-sethostname.c
+tests/macros.h
+
+Depends-on:
+sys_types
+
+configure.ac:
+
+Makefile.am:
+TESTS += test-sethostname
+check_PROGRAMS += test-sethostname
diff --git a/tests/test-sethostname.c b/tests/test-sethostname.c
new file mode 100644
index 0000000..249c064
--- /dev/null
+++ b/tests/test-sethostname.c
@@ -0,0 +1,117 @@
+/*
+ * Copyright (C) 2011 Free Software Foundation, Inc.
+ * Written by Ben Walton.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+#include <config.h>
+
+#include <unistd.h>
+
+#include "signature.h"
+SIGNATURE_CHECK (sethostname, int, (const char *, size_t));
+
+/* for HOST_NAME_MAX */
+#include <limits.h>
+/* for uid_t */
+#include <sys/types.h>
+/* for strlen */
+#include <string.h>
+
+#include <errno.h>
+#include <stdio.h>
+
+#include "macros.h"
+
+#define TESTHOSTNAME "gnulib-hostname"
+
+/* mingw and MSVC 9 lack geteuid, so setup a value that will indicate
+ we don't have root privilege since we wouldn't know whether to
+ expect success or failure when setting a name anyway*/
+#if !HAVE_GETEUID
+# define geteuid() ((uid_t) -1)
+#endif
+
+int
+main (int argc, char *argv[] _GL_UNUSED)
+{
+ char origname[HOST_NAME_MAX];
+ char newname[HOST_NAME_MAX];
+ char longname[HOST_NAME_MAX + 2];
+ int rcg, rcs, i;
+
+ /* skip the tests if we don't have root privilege. this does not
+ consider things like CAP_SYS_ADMIN (linux) or PRIV_SYS_ADMIN
+ (solaris), etc. systems without a working geteuid (mingw, MSVC
+ 9) will always skip this test. */
+ if (geteuid() != 0)
+ return 0;
+
+ /* we want to ensure we can do a get/set/get check to ensure the
+ change is accepted. record the current name so it can be restored
+ later */
+ ASSERT(gethostname (origname, sizeof (origname)) == 0);
+
+ /* try setting a valid hostname. if it fails -1/ENOSYS, we will
+ skip the test for long names as this is an indication we're using
+ the stub function that doesn't do anything on this platform. */
+ rcs = sethostname (TESTHOSTNAME, strlen (TESTHOSTNAME));
+
+ if (rcs != 0)
+ {
+ if (rcs == -1 && errno == ENOSYS)
+ return 0;
+ else
+ {
+ printf ("error setting valid hostname.\n");
+ return 1;
+ }
+ }
+ else
+ {
+ ASSERT (gethostname (newname, sizeof (newname)) == 0);
+
+ /* if we don't get back what we put in, there is no need to
+ restore the original name as we will assume it was not
+ properly changed. */
+ if (strcmp (newname, TESTHOSTNAME) != 0)
+ {
+ printf ("set/get comparison failed.\n");
+ return 1;
+ }
+ }
+
+ /* glibc does allow setting a zero length name, so the lower bound
+ needs no test. validate that we are constrained by
+ HOST_NAME_MAX */
+ for (i = 0; i < (HOST_NAME_MAX + 1); i++)
+ longname[i] = 'a';
+
+ longname[i] = '\0';
+
+ rcs = sethostname ((const char *) longname, (HOST_NAME_MAX + 1));
+
+ if (rcs != -1)
+ {
+ /* attempt to restore the original name. */
+ sethostname (origname, strlen (origname));
+ printf ("expected failure when setting very long hostname.\n");
+ return 1;
+ }
+
+ /* restore the original name. */
+ sethostname (origname, strlen (origname));
+
+ return 0;
+}
--
1.7.4.1
- Re: [RFC] sethostname handling patch series, Bruno Haible, 2011/12/01
- Re: [PATCH 4/4] Add a test suite for the sethostname module, Bruno Haible, 2011/12/03
- Re: [PATCH 4/4] Add a test suite for the sethostname module, Bruno Haible, 2011/12/03
- Re: [PATCH 4/4] Add a test suite for the sethostname module, Bruno Haible, 2011/12/03
- Re: [PATCH 4/4] Add a test suite for the sethostname module, Bruno Haible, 2011/12/04
[PATCH 2/4] Add a new sethostname module, Ben Walton, 2011/12/02