|
From: | Bruno Haible |
Subject: | Re: msvc-inval: more options |
Date: | Wed, 28 Sep 2011 11:47:57 +0200 |
User-agent: | KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; ) |
Jim Meyering wrote: > > -#if MSVC_INVALID_PARAMETER_HANDLING == DEFAULT_HANDLING > > +#if HAVE_MSVC_INVALID_PARAMETER_HANDLER \ > > + && MSVC_INVALID_PARAMETER_HANDLING == DEFAULT_HANDLING > > gl_msvc_inval_ensure_handler (); > > #endif > > That is a detail specific to MSVC. Why impose the readability and > maintenance hassle of requiring such an expression on all callers? It's not for all callers. It's only for specific tests. I could introduce a macro MSVC_INIT_INVALID_PARAMETER_HANDLER_FOR_TESTS_WITH_FUNCTIONS_WITHOUT_GNULIB_WORKAROUND() but that would be so special-purpose that I really wonder whether it's worth adding to msvc-inval.h. Bruno
[Prev in Thread] | Current Thread | [Next in Thread] |