[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: dropping close's dependency on fclose broke Octave's build system
From: |
Paul Eggert |
Subject: |
Re: dropping close's dependency on fclose broke Octave's build system |
Date: |
Mon, 25 Jul 2011 07:43:25 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11 |
On 07/24/11 18:01, Jordi Gutiérrez Hermoso wrote:
>
> http://octave.1599824.n4.nabble.com/Bootstrap-fails-tp3690747p3690963.html
>
> Not sure if we're doing something wrong in Octave with gnulib or if
> it's on your side.
Thanks for reporting the problem.
It's on gnulib's side. I installed the following patch, which solves the
immediate issue, at least for my test case. It'd be nice if someone
with expertise in Cygwin/mingw/whatever would think through the implications.
close: use gl_REPLACE_FCLOSE only if defined
* m4/close.m4 (gl_REPLACE_CLOSE): Use gl_REPLACE_FCLOSE only if it
is defined. The close module doesn't depend on the fclose module
any more, so gl_REPLACE_CLOSE's existence cannot be assumed. See
<http://lists.gnu.org/archive/html/bug-gnulib/2011-07/msg00392.html>.
I reproduced the problem with "./gnulib-tool --test close sys_socket".
diff --git a/m4/close.m4 b/m4/close.m4
index fc13138..0d8f67a 100644
--- a/m4/close.m4
+++ b/m4/close.m4
@@ -1,4 +1,4 @@
-# close.m4 serial 5
+# close.m4 serial 6
dnl Copyright (C) 2008-2011 Free Software Foundation, Inc.
dnl This file is free software; the Free Software Foundation
dnl gives unlimited permission to copy and/or distribute it,
@@ -22,5 +22,5 @@ AC_DEFUN([gl_REPLACE_CLOSE],
AC_REQUIRE([gl_UNISTD_H_DEFAULTS])
REPLACE_CLOSE=1
AC_LIBOBJ([close])
- gl_REPLACE_FCLOSE
+ m4_ifdef([gl_REPLACE_FCLOSE], [gl_REPLACE_FCLOSE])
])