bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] test-getcwd: don't stack-allocate PATH_MAX bytes


From: Bruno Haible
Subject: Re: [PATCH] test-getcwd: don't stack-allocate PATH_MAX bytes
Date: Tue, 21 Jun 2011 00:43:45 +0200
User-agent: KMail/1.9.9

Eric Blake wrote:
> --- a/tests/test-getcwd.c
> +++ b/tests/test-getcwd.c
> @@ -26,7 +26,6 @@
>  #include <string.h>
>  #include <sys/stat.h>
> 
> -#include "pathmax.h"
>  #include "macros.h"
> 
>  #if ! HAVE_GETPAGESIZE
> 

Hmm, this will now cause test_long_name to return immediately on HP-UX, without
performing a test. Is this intended? For GNU/Hurd it is intended, but for HP-UX
we know the right value is 1024, and "pathmax.h" defines it.

Bruno
-- 
In memoriam Neda Agha-Soltan <http://en.wikipedia.org/wiki/Neda_Agha-Soltan>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]