bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] Backport glibc change fixing Bugzilla bug #12378.


From: Bruno Haible
Subject: Re: [PATCH 1/2] Backport glibc change fixing Bugzilla bug #12378.
Date: Thu, 12 May 2011 02:57:35 +0200
User-agent: KMail/1.9.9

Hi James,

> +     Backport glibc change fixing Bugzilla bug #12378.

Thanks for doing this sync between gnulib and glibc.

> +         CHAR *p_init = p;
> +         CHAR *n_init = n;

No tabs in gnulib source code. Can you please untabify the file before
committing it in gnulib?

> +            if (!y ("@<:@/b", "@<:@/b", 0)) /* glibc Bugzilla bug 12378 */
> +              return 1;

You don't need to use quadrigraphs. Make sure that all pieces of C code are
properly quoted. In particular, the arguments of AC_LANG_PROGRAM should be
doubly-quoted: [[ ... ]]. Then you can use brackets in the C code as usual.
But you may need to balance them:

               if (!y ("[/b", "[/b", 0)) /* "]]" */ /* glibc Bugzilla bug 12378 
*/

Bruno
-- 
In memoriam Paul Bloomquist <http://en.wikipedia.org/wiki/Paul_Bloomquist>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]