[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: proposed patch for bootstrap
From: |
Bruce Korb |
Subject: |
Re: proposed patch for bootstrap |
Date: |
Wed, 06 Apr 2011 08:41:43 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110221 SUSE/3.1.8 Thunderbird/3.1.8 |
On 04/05/11 21:06, Gary V. Vaughan wrote:
AFAICT, very little (if anything) remains to be done short of actually
commiting it to the repository. I did stall on the horrid slurp function
shared among a few projects with slight divergences, but that is an
issue for bootstrap.conf files (if they haven't been sanitized already).
I'd suggest a couple of tweaks:
1. gnulib_non_module_files ought to be dependent upon not being set
by bootstrap.conf (as is the case), but also $build_aux.
if configure.ac or bootstrap.conf changes it, this variable will
not be correct.
2. Perhaps just my preference, but the embedded README/usage/help
text feels like too much clutter that belongs in associated
doc files rather than filling the first several hundred lines
of the script. :)
Clearly a well designed script. I vote for sanity checking the thing
and then plugging it in. :) Thanks, Gary.
Regards, Bruce
- proposed patch for bootstrap, Bruce Korb, 2011/04/05
- Re: proposed patch for bootstrap, Eric Blake, 2011/04/05
- Re: proposed patch for bootstrap, Bruce Korb, 2011/04/05
- Re: proposed patch for bootstrap, Eric Blake, 2011/04/05
- Re: proposed patch for bootstrap, Bruce Korb, 2011/04/05
- Re: proposed patch for bootstrap, Gary V. Vaughan, 2011/04/06
- Re: proposed patch for bootstrap,
Bruce Korb <=
- Re: proposed patch for bootstrap, Gary V. Vaughan, 2011/04/06
- Re: proposed patch for bootstrap, Bruce Korb, 2011/04/06
- Re: proposed patch for bootstrap, Gary V. Vaughan, 2011/04/07