From 497d58a9a8b9b8859603afd8fffbc8827ac03029 Mon Sep 17 00:00:00 2001 From: Reuben Thomas Date: Thu, 17 Mar 2011 07:43:08 +0000 Subject: [PATCH 2/3] Make valgrind stricter. --- ChangeLog | 6 ++++++ m4/valgrind-tests.m4 | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index d171ae7..57c270b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -267,6 +267,12 @@ (sc_po_check): Allow VPATH use. Reported by Jiri Denemark. +2011-03-17 Reuben Thomas + + valgrind: Do leak checking, and exit with code 1 on error (not 0). + * m4/valgrind-tests.m4: Add `--error-exitcode=1 --leak-check=full' + to VALGRIND. + 2011-03-16 Jim Meyering maint.mk: allow fine-grained syntax-check exclusion via Make variables diff --git a/m4/valgrind-tests.m4 b/m4/valgrind-tests.m4 index 8f90dac..ab9e25a 100644 --- a/m4/valgrind-tests.m4 +++ b/m4/valgrind-tests.m4 @@ -1,4 +1,4 @@ -# valgrind-tests.m4 serial 1 +# valgrind-tests.m4 serial 2 dnl Copyright (C) 2008-2011 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -23,7 +23,7 @@ AC_DEFUN([gl_VALGRIND_TESTS], if test -n "$VALGRIND" && $VALGRIND -q true > /dev/null 2>&1; then opt_valgrind_tests=yes - VALGRIND="$VALGRIND -q" + VALGRIND="$VALGRIND -q --error-exitcode=1 --leak-check=full" else opt_valgrind_tests=no VALGRIND= -- 1.7.1