Re: -Wundef warning in striconveh.h

[Andy Wingo]

Hi Eric,

On Thu 17 Mar 2011 15:05, Eric Blake <address@hidden> writes:

> On 03/17/2011 04:20 AM, Andy Wingo wrote:
>> striconveh.h:22 and striconveh.h:34 use #if when they should use #ifdef,
>> or something.
>
> Not a bug in gnulib,
>
>> 
>> Building Guile a contributor got this warning:
>
> but in guile.  Gnulib specifically documents that -Wundef is
> incompatible with gnulib modules, and that our coding style is
> deliberate.  -Wundef only catches portability problems for ancient
> (non-C89) compilers, and gnulib requires C89 as a bare minimum.  While
> you are free to use it for the rest of your project, you need to avoid
> it while compiling gnulib (or at least ignore the warnings and avoid
> -Werror).

This error did not occur while compiling gnulib (in the lib/) directory,
but rather libguile, which included striconveh.h.  I believe we already
follow your suggestions for building gnulib itself.

Can you consider changing this one header file?  It does not sound like
an issue on which it is fruitful to be stubborn.

See also this thread also:

  http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/24225

Do you have a response to Ludovic's concerns in his second message?

Regards,

Andy
-- 
http://wingolog.org/