[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: rename, renameat test failures on OSF/1
From: |
Eric Blake |
Subject: |
Re: rename, renameat test failures on OSF/1 |
Date: |
Wed, 22 Dec 2010 08:33:24 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7 |
On 12/22/2010 08:31 AM, Bruno Haible wrote:
> On OSF/1 5.1, I get these test failures:
>
> test-rename.h:342: assertion failed
> sh: 366977 Abort - core dumped
> FAIL: test-rename
>
> test-rename.h:342: assertion failed
> sh: 366978 Abort - core dumped
> FAIL: test-renameat
>
> The reason are different errno values. The following patch fixes it for me.
> OK to commit, or do you want to change the rename replacement to produce
> one of the expected errno values?
The patch to relax the testsuite looks okay to me; we're already
allowing other non-standard errno values here, so no one has complained
about it causing an actual problem in portability.
> - ASSERT (errno == EINVAL || errno == EBUSY);
> + ASSERT (errno == EINVAL || errno == EBUSY || errno == EEXIST);
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature