[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] iconv: fix deps
From: |
Bruno Haible |
Subject: |
Re: [PATCH] iconv: fix deps |
Date: |
Sun, 19 Dec 2010 11:15:28 +0100 |
User-agent: |
KMail/1.9.9 |
Hi Ian,
Ian Beckwith wrote:
> iconv fails the test suite due to a missing dep.
Thanks. This regression was introduced on 2010-11-26.
> Trivial patch attached.
Actually, the intent was that the 'iconv' module does not require the 'iconv-h'
module. The AM_ICONV macro is documented (in the gettext documentation) to be
usable on its own, and I find it good if testing the 'iconv' module also
tests that AM_ICONV can be used standalone. I'm therefore applying this
different fix:
2010-12-19 Bruno Haible <address@hidden>
iconv: Make it possible again to use this module without 'iconv-h'.
* modules/iconv (configure.ac): Don't invoke gl_ICONV_MODULE_INDICATOR
if it is not defined.
Reported by Ian Beckwith <address@hidden>.
--- modules/iconv.orig Sun Dec 19 11:09:36 2010
+++ modules/iconv Sun Dec 19 11:06:43 2010
@@ -9,7 +9,8 @@
configure.ac:
AM_ICONV
-gl_ICONV_MODULE_INDICATOR([iconv])
+m4_ifdef([gl_ICONV_MODULE_INDICATOR],
+ [gl_ICONV_MODULE_INDICATOR([iconv])])
Makefile.am: