Re: [PATCH 6/7] libposix: raw files to import an installable libposix project

[Bruce Korb]

Hi Gary,

On 10/12/10 09:08, Gary V. Vaughan wrote:

> +++ b/libposix/bootstrap
> @@ -0,0 +1,55 @@
> +#! /bin/sh
> +
> +PATH=..:$PATH
> +
> +gnulib-tool --import --lib=libposix --makefile-name=gnulib.mk \
> +  --macro-prefix=LIBPOSIX --libtool --no-changelog --symlink \
> +  --with-tests --with-c++-tests --with-longrunning-tests \
> +  libposix

The construction of the libposix project needs to happen inside
of a build directory.  It makes the process much cleaner.
I will rework this script to do that, please.  Thank you.

> +mv tests/gnulib.mk tests/Makefile.am
> +
> +# sanity check the module list for synchronisation issues.
> +echo "posix-modules :
> +`posix-modules`
> +libposix :
> +`gnulib-tool --extract-dependencies libposix`" |awk '

>   - A 36-lines awk script inside a Makefile? Isn't it more maintainable to
>     put it in a separate file?

I don't mind that so much, as long as the quoting is clean.
In this case, the script does not require any apostrophes,
so it isn't too bad.  I do find it easier to read when dropped
into a variable and then used as in:

   ... | awk "$awkcmd"

It disentangles the awk commands from the shell commands.

Cheers - Bruce