bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 6/7] libposix: raw files to import an installable libposix pr


From: Bruno Haible
Subject: Re: [PATCH 6/7] libposix: raw files to import an installable libposix project
Date: Tue, 12 Oct 2010 22:59:50 +0200
User-agent: KMail/1.9.9

Hi Gary,

> * libposix/bootstrap: New script to import gnulib posix modules
> and bootstrap configury so that the result is an installable
> libposix.la.
> * libposix/configure.ac: New file to configure the new libposix
> subdirectory.
> * libposix/Makefile.am: New file to delegate build duties to the
> generated libposix/lib/Makefile at make time.
> * libposix/lib/Makefile.am: New file to make sure `-version-info'
> is passed to libtool at libposix.la link-time.

This looks reasonable for a start. Additional files (for the version,
libtool version, texinfo documentation, etc.) can come afterwards.

Just three remarks:
  - It would be better to invoke 'posix-modules' from within 'bootstrap',
    as mentioned in the reply to [PATCH 4/7].
  - No tabs except where necessary, please.
  - A 36-lines awk script inside a Makefile? Isn't it more maintainable to
    put it in a separate file?

Bruno



reply via email to

[Prev in Thread] Current Thread [Next in Thread]