Re: uninstalling relocation wrappers

[Ralf Wildenhues]

Hello,

* Bruno Haible wrote on Mon, Jun 14, 2010 at 02:06:55AM CEST:
> > +uninstall-hook: uninstall-relocwrapper
> > +uninstall-relocwrapper:
> > +if RELOCATABLE_VIA_LD
> > +   @:
> > +else
> > +   if test $(RELOCATABLE) = yes; then \
> > +       case '$(EXEEXT)' in \
> > +           .bin*) ;; \
> > +           *) $(MAKE) uninstall EXEEXT=.bin$(EXEEXT) ;; \
> > +       esac; \
> > +   fi
> > +endif
> 
> Hmm, I don't like targets that contain empty commands in the default
> case (when no relocatability is requested): it looks like bloat.

FYI, good make implementations are able to optimize this case away.

> Instead, I would better see an AC_SUBSTed and AM_SUBST_NOTMAKEd variable
> that expands to
> 
>    uninstall-hook:
> 
> if RELOCATABLE_VIA_WRAPPER is false, and to
> 
>    uninstall-hook: uninstall-relocwrapper
>    uninstall-relocwrapper: ; case '$(EXEEXT)' in .bin*) ;; *) $(MAKE) 
> $(AM_MAKEFLAGS) uninstall EXEEXT=.bin$(EXEEXT) ;; esac
> 
> if RELOCATABLE_VIA_WRAPPER is true. Unfortunately, I don't see how to
> reduce this to a single line; this would make it unnecessary to rely on
> AM_SUBST_NOTMAKE - but how?

Well, you could make it two variables.

Cheers,
Ralf