[PATCH] maint.mk: don't silently disable project-specific syntax-check rules

[Jim Meyering]

I realized that the recent variable name change was actually
rather insidious.  It would silently disable project-specific
syntax-check rules that used the old name.  That made it very
likely that someone would not notice, and would never upgrade
to use the new name, _sc_search_regexp.

This new definition prevents that.

>From 219c504b3178a07389eef1cd411bde3864f3f54c Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 3 Apr 2010 18:03:16 +0200
Subject: [PATCH] maint.mk: don't silently disable project-specific syntax-check 
rules

* top/maint.mk (_prohibit_regexp): Define, to help people realize
that they need to convert their project-specific syntax-check rules
to use the new _sc_search_regexp.
---
 ChangeLog    |    7 +++++++
 top/maint.mk |    9 +++++++++
 2 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 3f33302..36443a3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2010-04-03  Jim Meyering  <address@hidden>
+
+       maint.mk: don't silently disable project-specific syntax-check rules
+       * top/maint.mk (_prohibit_regexp): Define, to help people realize
+       that they need to convert their project-specific syntax-check rules
+       to use the new _sc_search_regexp.
+
 2010-04-03  Bruno Haible  <address@hidden>

        fchdir: Fix regression introduced on 2010-03-08.
diff --git a/top/maint.mk b/top/maint.mk
index 13a0438..3038680 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -189,6 +189,15 @@ define _sc_say_and_exit
    { echo -e "$(ME): $$msg" 1>&2; exit 1; };
 endef

+# _sc_search_regexp used to be named _prohibit_regexp.  However,
+# upgrading to the new definition and leaving the old name undefined
+# would usually convert each custom rule using $(_prohibit_regexp)
+# (usually defined in cfg.mk) into a no-op.  This definition ensures
+# that people know right away if they're still using the old name.
+# FIXME: remove in 2012.
+_prohibit_regexp = \
+  $(error '*** you need to s/_prohibit_regexp/_sc_search_regexp/, and adapt')
+
 define _sc_search_regexp
    dummy=; : so we do not need a semicolon before each use;            \
                                                                        \
--
1.7.0.4.529.g78fb