Re: [PATCH] Fix use of ENABLE_NLS (which is not always defined)

[Eric Blake]

On 03/16/2010 05:59 PM, Grégoire Sutre wrote:
>> In fact, any package which makes good use of Autoconf cannot support
>> -Wundef.
> 
> I don't see why.  Could you please elaborate?

AC_CHECK_FUNCS leaves HAVE_FUNC undefined if it is missing, but defines
HAVE_FUNC to 1 if it is present.  It is much easier to write:

#if HAVE_FUNC

than it is to write

#if defined HAVE_FUNC && HAVE_FUNC

everywhere that you want to use the default results provided by
autoconf.  That's why gnulib does NOT want to cater to -Wundef.

I won't go as far as Bruno's statement; if you want to use both autoconf
and -Wundef in your files, then more power to you.  That is, I see no
fundamental reason why using autoconf means you can't make the extra
effort to do the redundant typing to silence -Wundef.  But I agree with
Bruno's sentiment that it is a waste of time, and won't do it in any of
my packages.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature