bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

module include recommendation


From: Eric Blake
Subject: module include recommendation
Date: Mon, 25 Jan 2010 22:44:23 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

I noticed this while bootstrapping m4; <ignore-value.h> stood out like a sore 
thumb when sorted among the list of system headers, when all other gnulib-
specific headers used by m4 used "".  Any objections to this patch?  I did not 
touch eealloc, although that is another module that could probably be changed 
in the same manner.


From: Eric Blake <address@hidden>
Date: Mon, 25 Jan 2010 15:42:55 -0700
Subject: [PATCH] ignore-value: update recommended header name

* modules/ignore-value (Include): Only use <> for headers that
exist in glibc.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog            |    6 ++++++
 modules/ignore-value |    2 +-
 2 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index ee23708..9779709 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-01-25  Eric Blake  <address@hidden>
+
+       ignore-value: update recommended header name
+       * modules/ignore-value (Include): Only use <> for headers that
+       exist in glibc.
+
 2009-11-17  Eric Blake  <address@hidden>

        manywarnings: add more warnings
diff --git a/modules/ignore-value b/modules/ignore-value
index d43200e..8d48863 100644
--- a/modules/ignore-value
+++ b/modules/ignore-value
@@ -13,7 +13,7 @@ Makefile.am:
 lib_SOURCES += ignore-value.h

 Include:
-<ignore-value.h>
+"ignore-value.h"

 License:
 LGPLv2+
-- 
1.6.4.2







reply via email to

[Prev in Thread] Current Thread [Next in Thread]