bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnulib-tool: fix filelist for AIX, HP-UX ksh


From: Bruno Haible
Subject: Re: gnulib-tool: fix filelist for AIX, HP-UX ksh
Date: Sun, 17 Jan 2010 04:59:05 +0100
User-agent: KMail/1.9.9

Hello Ralf,

Ralf Wildenhues wrote:
> AIX and HP-UX ksh do not like expanding an empty variable in a
> double-quoted shell case pattern:
> 
> $ sh -c 'foo=""; case x in "$foo"*) echo good;; $foo*) echo hmm;; esac'
> hmm
> $ bash -c 'foo=""; case x in "$foo"*) echo good;; $foo*) echo hmm;; esac'
> good
> 
> This causes differences in the generated {gllib,gltests}/Makefile.am
> files.

Weird...

> The fix is to simply avoid the quotes.  I added a documentation note
> of caution

It's ugly, but with good comments it's OK. Can you add a comment explaining
the rationale of omitting the double-quotes very near? Rationales belong
in comments, not (only) in the ChangeLog entry.

Thanks!

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]