[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix build failure with getline.c
From: |
Eric Blake |
Subject: |
Re: [PATCH] fix build failure with getline.c |
Date: |
Fri, 01 Jan 2010 17:20:41 -0700 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Robert Millan on 1/1/2010 4:24 PM:
>> Aren't you using the gnulib stdio module, or is the code not working
>> somehow?
>>
> So no, the stdio module wasn't being included. Maybe you want to consider
> removing this dependency, I think other projects could be in a similar
> situation than GRUB is.
Removing the dependency seems like a step backwards. The point of the
header replacement modules is so that the rest of the code can assume a
compliant header. Glibc's header is not yet compliant to POSIX 2008, so
importing the stdio module into GRUB seems like a better fix than changing
getline.c in gnulib.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAks+kVkACgkQ84KuGfSFAYC1PACg121wNt8wQ7+OFk7qUiQcvSJ0
iDwAnjBi1GQZdAy46ujBh0v+oefxK26B
=CYlR
-----END PGP SIGNATURE-----