bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: add pipe2-safer


From: Eric Blake
Subject: Re: add pipe2-safer
Date: Thu, 10 Dec 2009 18:32:41 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Bruno Haible on 12/10/2009 6:19 PM:
> Is there any reason why the pipe2_safer code is not in a file of its own?

Only because unistd-safer didn't split fd_safer_flag and dup_safer_flag
into separate files.

> Here is a proposed patch:

It looks okay, except for:

> +          fd[i] = fd_safer_flag (fd[i], flags);

unistd-safer.h doesn't declare fd_safer_flag unless the cloexec module was
also in use.  Therefore,

>  Depends-on:
> -cloexec

...I think this portion of the change is incorrect.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkshoTkACgkQ84KuGfSFAYD/BgCgtiMM0PtgSmV2P1VrTFcfE79k
VNoAn0N5BX7Ky0dvKpT36wW7euAOp1La
=18SG
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]