bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

link (was: mkfifoat, renameat)


From: Eric Blake
Subject: link (was: mkfifoat, renameat)
Date: Sat, 19 Sep 2009 20:28:00 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Eric Blake on 9/9/2009 5:31 PM:
> Meanwhile, I noticed that the link module has a bug on mingw, where link
> ("a","b/.") created the regular file "b" rather than failing with ENOENT (I 
> noticed it because cygwin 1.5 had the same bug, and I noticed that while 
> enhancing the link module to work around Solaris 8 handling of trailing / in 
> link).  I'll probably be applying this soon...
> 
> +         [gl_cv_func_link_works=yes], [gl_cv_func_link_works=no],
> +         [gl_cv_func_link_works="guessing no"])
> +       rm -f conftest.a conftest.b])
> +    if test $gl_cv_func_link_works != yes; then

Oops - syntax error on cross-compilation.  Committing this:

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkq1kzAACgkQ84KuGfSFAYBKMwCeK8T06Oka158MjalCTCLarvJ9
xXkAoNFU3BHF9xgiYcrWdP9vAJd7d91p
=nOOl
-----END PGP SIGNATURE-----
>From 8bfee8687b37d280d51793774be0fa79070eafa1 Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Sat, 19 Sep 2009 20:17:33 -0600
Subject: [PATCH] link: fix quoting

* m4/link.m4 (gl_FUNC_LINK): Fix shell quoting.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog  |    3 +++
 m4/link.m4 |    4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 94b8465..0f0b954 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2009-09-19  Eric Blake  <address@hidden>

+       link: fix quoting
+       * m4/link.m4 (gl_FUNC_LINK): Fix shell quoting.
+
        openat: fix openat bugs on Solaris 9
        * lib/openat.c (rpl_openat): Work around Solaris 9 bug.
        * m4/openat.m4 (gl_FUNC_OPENAT): Also replace openat on Solaris.
diff --git a/m4/link.m4 b/m4/link.m4
index fc071cd..a212ee2 100644
--- a/m4/link.m4
+++ b/m4/link.m4
@@ -1,4 +1,4 @@
-# link.m4 serial 2
+# link.m4 serial 3
 dnl Copyright (C) 2009 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -22,7 +22,7 @@ AC_DEFUN([gl_FUNC_LINK],
          [gl_cv_func_link_works=yes], [gl_cv_func_link_works=no],
          [gl_cv_func_link_works="guessing no"])
        rm -f conftest.a conftest.b])
-    if test $gl_cv_func_link_works != yes; then
+    if test "$gl_cv_func_link_works" != yes; then
       REPLACE_LINK=1
       AC_LIBOBJ([link])
     fi
-- 
1.6.5.rc1


reply via email to

[Prev in Thread] Current Thread [Next in Thread]